Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub reports for is-validated command #1529

Merged
merged 23 commits into from
Apr 25, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Apr 19, 2024

Closes #1508

Description

Fetches the report from GitHub instead of looking at the on chain data.

Failure result:

Screenshot 2024-04-24 at 2 34 39 PM

Success result:

Screenshot 2024-04-24 at 2 38 16 PM

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink changed the base branch from master to feature/stable-cadence April 19, 2024 15:23
@jribbink jribbink force-pushed the jribbink/validate-fix branch from 38908a3 to 3b11871 Compare April 19, 2024 19:40
@jribbink jribbink changed the title Jribbink/validate fix Use GitHub reports for is-validated command Apr 19, 2024
@jribbink jribbink marked this pull request as ready for review April 19, 2024 20:52
@jribbink jribbink marked this pull request as draft April 19, 2024 21:39
@jribbink jribbink marked this pull request as ready for review April 19, 2024 21:52
internal/migrate/is_validated.go Outdated Show resolved Hide resolved
internal/migrate/is_validated.go Outdated Show resolved Hide resolved
internal/migrate/is_validated.go Outdated Show resolved Hide resolved
internal/migrate/is_validated.go Outdated Show resolved Hide resolved
internal/migrate/is_validated.go Outdated Show resolved Hide resolved
internal/migrate/is_validated.go Outdated Show resolved Hide resolved
@jribbink jribbink merged commit 4a6be25 into feature/stable-cadence Apr 25, 2024
5 checks passed
@jribbink jribbink deleted the jribbink/validate-fix branch April 25, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants